[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719854

--- Comment #5 from Steve Traylen <steve.traylen@xxxxxxx> 2011-07-09 15:35:08 EDT ---
Hi, 

1)
I'm afraid the build still fails:

1xmlparser.c:50:24: fatal error: xmlparse.h: No such file or directory

to check the dependencies are correct you should definitely be 
checking with mock:

 mock -r fedora-rawhide-x86_64 \
     --rebuild ../SRPMS/rubygem-xmlparser-0.6.81-2.fc15.src.rpm

 will produce the above error.

2)
Concerning the "Your %build section references %{SOURCE0}" I'll try
to explain better.

Source0: http://whatever.org/%{gemname}-%{version}.gem

was correct, the URL before the file name is all only informational 
anyway but of course very useful.

What I did not explain well is that during %prep you prepare all your
sources into a directory ready for building.

So
%prep
%setup -q -c -T

copies the file over to a fresh directory and then %build
should be the following to operate on those files.

gem install -V --local --install-dir $(pwd)/%{gemdir} \
  --no-rdoc --no-ri --force %{gemname}-%{version}.gem

The problem with %{SOURCE0} is that this expands to the full source location,
probably $HOME/rpmbuilds/SOURCES/%{gemname}-%{version}.gem

3)
I expect 
BuildRequires: ruby-devel, rubygem-rake, rubygem-mkrf

is wrong and reubygems should be specified as 

BuildRequires: rubygem(mkrf), rubygem(rake)

Check some existing rubygem packages to see what they do.
e.g. 
http://pkgs.fedoraproject.org/gitweb/?p=rubygem-rake.git;a=blob;f=rubygem-rake.spec;h=9accf911a5cd25db4d4dbe392341f35a6f4d8dde;hb=HEAD

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]