[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

--- Comment #5 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> 2011-07-09 14:49:00 EDT ---
spec: http://gomix.fedorapeople.org/rubygem-rhc/rubygem-rhc.spec
srpm:
http://gomix.fedorapeople.org/rubygem-rhc/rubygem-rhc-0.71.2-2.fc15.src.rpm

* Package now owns %{gemdir}/gems/%{gemname}-%{version}/
* Licence fixed to MIT.
* Missuse of %dir corrected.
* Better URL done.
* User binaries moved to the right place.
* Should everything in /usr/lib/ruby/gems/1.8/doc/rhc-0.71.2 be marked doc?

  Yes, none of those files are dependencies for runtime execution and can be
safely removed without breaking a thing. yaml files are used by ri ruby online
documentation system. rdoc is html formatted versions.

rpmlint outputs

$ rpmlint -i SPECS/rubygem-rhc.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -i SRPMS/rubygem-rhc-0.71.2-2.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -i RPMS/noarch/rubygem-rhc-0.71.2-2.fc15.noarch.rpm 
rubygem-rhc.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/rhc-0.71.2/ri/RHC/hostexist%3f-c.yaml %3f
This package contains a file whose path contains something that looks like an
unexpanded macro; this is often the sign of a misspelling. Please check your
specfile.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-ctl-app
Each executable in standard binary directories should have a man page.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-snapshot
Each executable in standard binary directories should have a man page.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-create-app
Each executable in standard binary directories should have a man page.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-user-info
Each executable in standard binary directories should have a man page.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-create-domain
Each executable in standard binary directories should have a man page.

rubygem-rhc.noarch: W: no-manual-page-for-binary rhc-tail-files
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 0 errors, 7 warnings.

besides lack of man pages, yaml-rpmlint reporting issue is ignorable.

it looks better now, thanks for reviewing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]