Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675050 --- Comment #16 from Kaleb KEITHLEY <kkeithle@xxxxxxxxxx> 2011-07-08 14:17:27 EDT --- WRT license issue— I removed rb.c from the SRPM, it's not needed. I changed the license on rbmap.c to AGPL. I wrote it and put the wrong license in it. Leaving, for the moment, only rb.h. rb.h (and rb.c) came from glusterfs' contrib and rb.c is compiled into libglusterfs in the glusterfs RPM. (I suppose that technically this means that the glusterfs RPM has a license issue.) The glusterfs-devel package does not install rb.h. I can deal with this a number of different ways: 1) write the function decls I need into rbmap.c and continue to link against libglusterfs with its license issue. 2) refactor rbmap.c to use AVL tree impl. in avl.rpm/libavl. License is LGPL. 3) refactor rbmap.c to use rbtree hashmap impl. in libHX.rpm/libHX. License is LGPL. 4) refactor rbmap.c to use a BSD licensed rbtree impl. from *BSD. All the above include removing rb.h from the source N.B. Curiously rb.[ch] have comments that seem to imply that it came from avl, but it bears no resemblance to anything in avl. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review