Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |BuildFails --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2011-07-08 14:15:59 EDT --- Hi Ulrich, Thanks for submitting the review, A quick glance at the .spec file I notice the following things: 1) Your %build section references %{SOURCE0} which of course refers directly to your source. You need to prepare you source in %prep into a new directory and then build what you have prepared. 2) The .spec file contains some commented out lines, e.g #rm -f %{buildroot}%{gemdir}/gems/xmlparser-0.6.81/ext/xmlparser/*.so #rm -f %{buildroot}%{gemdir}/gems/xmlparser-0.6.81/ext/xmlparser/*.o for no apparent reason, at the very least it should be commented to as to why but probably it should just go. 3) You use %define and %global at the top, should almost always be %global. http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define Now actually trying the .src.rpm. 4) Building on F15 results in: ERROR: Error installing /home/steve/rpmbuild/SOURCES/xmlparser-0.6.81.gem: ERROR: Failed to build gem native extension. Since it does not build I've added "BuildFails" to the whiteboard above, be sure to remove that once the package builds. I confess I don't know the ruby guidelines well so if I contradict anything in those I may well be wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review