Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680936 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@xxxxxxx --- Comment #8 from David Nalley <david@xxxxxxx> 2011-07-07 19:57:28 EDT --- Chris: Please increment release in your spec/srpm when making changes even if trivial, it makes it much easier on the reviewer when installing your SRPM. http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag In your source URL is there a reason you can't use this as the source URL? https://github.com/wallunit/ssh4py/zipball/0.7.1 It would still have to be a commented troublesome source url, and it'd screw up the macros, but at least it permits upstream source to be verifiable, and less work for others. I don't see it as a blocker, but perhaps something to consider. Kaleb: Can you run rpmlint on this package (spec file, SRPM, and binary RPM(s)) and paste the content in the review. Can you also paste the result of md5sum comparing source in srpm and at Source URL? In this particular case it won't work because of the special means to get to a tarball, but that at least needs to be commented in the review. Thanks for taking this on. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review