Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680936 --- Comment #7 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-07-05 13:12:49 EDT --- (In reply to comment #6) > (new) fedora guidelines say: > + BuildRoot is unnecessary, just get rid of it > + %defattr, ditto > + %clean, ditto Thanks for the review. I had submitted this package before I knew about those new guidelines, so thanks for the reminder. I've now fixed those and uploaded new versions of the spec and SRPM to the same place. Kaleb, in general when reviewing packages the procedure is to assign the bug to yourself, set the state to ASSIGNED, and also set the fedora-review flag to ?. Once you are satisfied that the package meets criteria, you then switch the fedora-review flag to +, and then I'll complete the rest of the process. Thanks again, Chris Lalancette -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review