Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715180 --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-07-02 05:39:24 EDT --- (In reply to comment #1) > One file is licensed as GPLv3+. Please ask upstream and also inform them of the > wrong address, though that is not a blocker. Emailed upstream. What file is this please? I can't find it. :/ > > "FreeMat is available under the GPL license." -- That part of the description > is useless. dropped. > > Drop all the "-v"s. rpmbuild shows everything by default. Add -f to your last > rm. mock will show the command, but not verbose execution of rm. > > The description text sounds a lot like in this example: > http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description > removed concerned portion > Please do as rpmlint says and correct the line ends with something like: > > http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding > > rpmlint -I can help, if you don't understand what an error is about. > corrected. > Also mend that: > > freemat.i686: W: devel-file-in-non-devel-package > /usr/share/FreeMat-4.1/toolbox/test/addArrays.c It's a test file for users that the package installs. I think we can let it be. > > Either define a Buildroot tag, if you want to put this package to EPEL 5, or > drop: rm -rf $RPM_BUILD_ROOT dropped > > The defattr line is unneeded. dropped > > Can you probably generate the current documentation? I've tried, but been unable to. I've informed upstream of this. Whenever they generate the new doc, I'll push a new build. > > Really delete the bundled libs. Currently there is a pound sign in front of it. deleted > > CMake informs about: > > -- Could NOT find Boost It isn't causing the build to fail, so I guess it's okay. I will clarify with upstream though. > Compiler optimization may lead to broken Lapack build. > If release build produces incorrect results (e.g. svd(rand(4)) is all NaN) > you should to disable optimization when compiling dlamch.c and slamch.c > > Did you make sure that's fine? I'm using the fedora lapack package so this is irrelevant IMO. rpmlint output: [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm freemat.i686: W: devel-file-in-non-devel-package /usr/share/FreeMat-4.1/toolbox/test/addArrays.c freemat.i686: E: incorrect-fsf-address /usr/share/FreeMat-4.1/toolbox/general/license.m freemat.i686: E: incorrect-fsf-address /usr/share/doc/freemat-20110620/COPYING freemat.i686: W: no-manual-page-for-binary FreeMat freemat.src: W: invalid-url Source0: freemat.tar.gz freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/HandleList.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/DebugStream.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/main.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/application.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/SymbolTable.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libGraphics/HandleFigure.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/FuncTerminal.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/HistoryWidget.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/Terminal.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Token.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libGraphics/RenderEngine.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Exception.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/DataTable.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/NTuple.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/DumbTerminal.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Array.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Stream.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/QTTerm.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/FunctionDef.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/StackTool.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/FuncMode.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/Terminal.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/FileTool.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Scope.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/DebugWin.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/FMFontDialog.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Vector.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/MainApp.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/FuncTerminal.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/MainApp.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/FastList.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/application.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/FuncMode.cpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/ArrayPrivate.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/BasicArray.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libGraphics/HandleWindow.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Context.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Interpreter.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/KeyManager.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/Editor.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libFreeMat/Types.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libGraphics/HandleCommands.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libGraphics/HandleProperty.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/libs/libXP/VariablesTool.hpp freemat-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/freemat/FreeMat/src/DumbTerminal.hpp 3 packages and 0 specfiles checked; 47 errors, 3 warnings. The new package is uploading. I'll provide the srpm in a few minutes. Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review