Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715180 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2011-06-24 19:05:37 EDT --- One file is licensed as GPLv3+. Please ask upstream and also inform them of the wrong address, though that is not a blocker. "FreeMat is available under the GPL license." -- That part of the description is useless. Drop all the "-v"s. rpmbuild shows everything by default. Add -f to your last rm. The description text sounds a lot like in this example: http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description Please do as rpmlint says and correct the line ends with something like: http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding rpmlint -I can help, if you don't understand what an error is about. Also mend that: freemat.i686: W: devel-file-in-non-devel-package /usr/share/FreeMat-4.1/toolbox/test/addArrays.c Either define a Buildroot tag, if you want to put this package to EPEL 5, or drop: rm -rf $RPM_BUILD_ROOT The defattr line is unneeded. Can you probably generate the current documentation? Really delete the bundled libs. Currently there is a pound sign in front of it. CMake informs about: -- Could NOT find Boost Compiler optimization may lead to broken Lapack build. If release build produces incorrect results (e.g. svd(rand(4)) is all NaN) you should to disable optimization when compiling dlamch.c and slamch.c Did you make sure that's fine? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review