Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717645 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-06-30 12:14:39 EDT --- (In reply to comment #3) > > * you do not provide -doc subpackage, although I am not sure if we should not > > disable the documentation for this gem at all > > Hm, I'm really fine either way. I guess it does make sense to have the -doc > package, like other rubygems. I've taken that bit from yours and put it into > mine. I just checked the content of the documentation when I did the package myself and there was virtually nothing, that why I doubt if it would not be better to disable it at all, but on the other hand, it is not installed by default. So lets keep it the way it is now. And I found yet another minor nit. You keep the .gemspec file which is in gem folder but it has no meaning in our package, so I suggest to remove it: %exclude %{geminstdir}/%{gemname}.gemspec And the final one, you are using "Requires: rubygems" where it should be better to use the virtual provide "Requires: ruby(rubygems)". The same apply for BR. Otherwise the package looks good. So I APPROVE it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review