Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717645 --- Comment #3 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-06-30 11:56:24 EDT --- (In reply to comment #1) > Hi Chris, > > by coincidence, I did the same package today before I noticed you did that > yesterday :) So you can take a look for comparison [1]. A few things I noticed > in you spec file: > > * Wrong license Oops, fixed. > * site_libdir is useless for gem packages Yep, removed. > * you do not provide -doc subpackage, although I am not sure if we should not > disable the documentation for this gem at all Hm, I'm really fine either way. I guess it does make sense to have the -doc package, like other rubygems. I've taken that bit from yours and put it into mine. > * %defattr is no more needed except EPEL-4 > * BuildRoot is deprecated, except EPEL-5 and older I guess > * Clean section is not required anymore Heh, I had no idea. But re-reading the packaging guidelines, I see that this is indeed the case. I've removed all 3 of these. > * There is better to use %{geminstdir} macro in %files section Fixed. (In reply to comment #2) > And you did not specified ruby(abi) Right, fixed. I've re-uploaded the SPEC and SRPM to the same place; can you take a look when you get a chance? Thanks, Chris Lalancette -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review