Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711048 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-06-28 12:13:34 EDT --- Two things: * You don't need the %defattr line anymore. I probably should have called it out on the other review too, but its really a minor item. * The proper license for this data is: GPLv3 or GPLv3+ or GPLv2+ or Public Domain or CC-BY or CC-BY-SA (Yes, I looked it up when I did my package, thats how I know. :) ) Make those two changes and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review