Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review+ --- Comment #5 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-06-28 12:11:01 EDT --- Huh. The %{_mandir}/man6/* line should be correct, what was unnecessary was the %doc in front of it. Good: - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (cbaa09d036188a22c0c9c70f1db6e00923b138ff897cdd37072adf4a438a503d) - package compiles on F-15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3164092) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file OK APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review