Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 Elad Alfassa <el.il@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |el.il@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |el.il@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Elad Alfassa <el.il@xxxxxxxxxx> 2011-06-16 05:04:49 EDT --- I'll do the review. + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: 6a2549ac55216cbb62dc2079b6dc4f46 cogl-1.7.0.tar.bz2 - Package needs ExcludeArch - BuildRequires correct + Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun + .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. + -devel package Requires: %{name} = %{version}-%{release} + .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. - Package owns all the directories it creates. ? No rpmlint output. [elad@elephant SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/cogl-* cogl.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cogl.src: W: spelling-error %description -l en_US drm -> rm, dram, dorm cogl.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cogl.x86_64: W: spelling-error %description -l en_US drm -> rm, dram, dorm cogl.x86_64: W: shared-lib-calls-exit /usr/lib64/libcogl.so.0.0.0 exit@xxxxxxxxxxx cogl.x86_64: E: incorrect-fsf-address /usr/share/doc/cogl-1.7.0/COPYING cogl-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 6 warnings. Spelling errors and the no-documentation error can be ignored, but please fix the FSF address (and submit a patch to upsteam with the fix) + final provides and requires are sane: cogl-1.7.0-1.fc16.src.rpm = cairo-devel glib2-devel gobject-introspection-devel gtk-doc libXcomposite-devel libXdamage-devel libXext-devel libXfixes-devel mesa-libGL-devel pango-devel pkgconfig rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 cogl-1.7.0-1.fc16.x86_64.rpm libcogl-pango.so.0()(64bit) libcogl.so.0()(64bit) cogl = 1.7.0-1.fc16 cogl(x86-64) = 1.7.0-1.fc16 = /sbin/ldconfig /sbin/ldconfig libGL.so.1()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libcairo.so.2()(64bit) libcogl.so.0()(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.2.5)(64bit) libdrm.so.2()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) librt.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 cogl-debuginfo-1.7.0-1.fc16.x86_64.rpm cogl-debuginfo = 1.7.0-1.fc16 cogl-debuginfo(x86-64) = 1.7.0-1.fc16 = rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 cogl-devel-1.7.0-1.fc16.x86_64.rpm pkgconfig(cogl-1.0) = 1.7.0 pkgconfig(cogl-2.0-experimental) = 2.0.0 pkgconfig(cogl-gl-1.0) = 1.7.0 pkgconfig(cogl-pango-1.0) = 1.7.0 pkgconfig(cogl-pango-2.0-experimental) = 1.7.0 cogl-devel = 1.7.0-1.fc16 cogl-devel(x86-64) = 1.7.0-1.fc16 = /usr/bin/pkg-config cogl = 1.7.0-1.fc16 fontconfig-devel glib2-devel gobject-introspection-devel libcogl-pango.so.0()(64bit) libcogl.so.0()(64bit) mesa-libGL-devel pango-devel pkgconfig pkgconfig(cogl-1.0) pkgconfig(gl) pkgconfig(glib-2.0) pkgconfig(libdrm) pkgconfig(pangocairo) >= 1.20 pkgconfig(x11) pkgconfig(xcomposite) >= 0.4 pkgconfig(xdamage) pkgconfig(xext) pkgconfig(xfixes) >= 3 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 cogl-doc-1.7.0-1.fc16.noarch.rpm cogl-doc = 1.7.0-1.fc16 = cogl = 1.7.0-1.fc16 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Seems fine. SHOULD Items: + Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. + Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Issues: 1. Wrong FSF address in copying, cogl.x86_64: E: incorrect-fsf-address /usr/share/doc/cogl-1.7.0/COPYING, please report upstream (and submit a patch to fix it). 2. Why is the package named cogl but the description (of doc) says clutter? Looks like you copied some parts from clutter's spec file and forgot to change some parts. Apart from these two small issues, it's all good. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review