Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #27 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-16 04:42:49 EDT --- Hi Peter, (In reply to comment #25) > Hello! > > (In reply to comment #24) > > Hello, > > > > An informal review :D > > Ankur, please, reassign this ticket to yourself - I don;t have free time to > compolete the review in the next week or two. I'll do that :) Thanks, (In reply to comment #26) > Hi all! > > @Ankur: thanks a lot for your input! > I'll review klt and agree that the other libs should stay bundled. > I'm not familiar with the "final provides and requires are sane:" and > "review-req-check" parts. What exactly should I do here? Hi Mario, You need to just look at the list and see if the requires and provides are what they should be ;) review-req-check is just an alias: alias review-req-check='for i in *rpm; do echo "== $i =="; echo "Provides:"; rpm -qp --provides $i | sed "/rpmlib.*/d" ; echo ; echo "Requires:" ; rpm -qp --requires $i | sed "/rpmlib.*/d"; echo; done'$ > > @Peter: ok thank you for bringing me so far :) > > Best, > > Mario Thanks for taking klt Mario, Thanks Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review