Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713320 --- Comment #3 from Steven Dake <sdake@xxxxxxxxxx> 2011-06-15 09:33:10 EDT --- Summary of MUST review blockers: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] FAIL: there are a few problems in the rpmlint results. This is a BLOCKER. the source rpm [sdake@beast Downloads]$ rpmlint oz*src.rpm oz.src: W: non-standard-group Development oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. the rpm: [sdake@beast noarch]$ rpmlint oz* oz.noarch: W: non-standard-group Development oz.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash 1 packages and 0 specfiles checked; 1 errors, 1 warnings. 1. Source0 should be a full url. I recommend: I recommend: Source0: http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz 2. Group should either be "Development Tools" or "Development Libraries". 3. icicle-nc should have its permissions set to 755.MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] FAIL: there are a few problems in the rpmlint results. This is a BLOCKER. the source rpm [sdake@beast Downloads]$ rpmlint oz*src.rpm oz.src: W: non-standard-group Development oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. the rpm: [sdake@beast noarch]$ rpmlint oz* oz.noarch: W: non-standard-group Development oz.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash 1 packages and 0 specfiles checked; 1 errors, 1 warnings. 1. Source0 should be a full url. I recommend: I recommend: Source0: http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz 2. Group should either be "Development Tools" or "Development Libraries". 3. icicle-nc should have its permissions set to 755. MUST: The License field in the package spec file must match the actual license. [3] FAIL: The COPYING file and header files indicate the code is licensed under lgplv2.1, however, spec file indicates code licensed under lgplv2 MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. The source0 package should be the upstream package location including url. upstream package: from SRC RPM: FAIL - md5sums do not match this is a BLOCKER [sdake@beast Downloads]$ md5sum oz-0.4.0.tar.gz cd1639af62509c677c95d94705042772 oz-0.4.0.tar.gz md5sum [sdake@beast SOURCES]$ md5sum oz-0.4.0.tar.gz d2f774e97ca5ac0c34b9f07b6ea1bd01 oz-0.4.0.tar.gz MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] FAIL - icicle-nc is not set with execute permissions - THIS IS A BLOCKER -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review