Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713320 --- Comment #2 from Steven Dake <sdake@xxxxxxxxxx> 2011-06-15 09:28:45 EDT --- MUST review: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] FAIL: there are a few problems in the rpmlint results. This is a BLOCKER. the source rpm [sdake@beast Downloads]$ rpmlint oz*src.rpm oz.src: W: non-standard-group Development oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. the rpm: [sdake@beast noarch]$ rpmlint oz* oz.noarch: W: non-standard-group Development oz.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash 1 packages and 0 specfiles checked; 1 errors, 1 warnings. 1. Source0 should be a full url. I recommend: I recommend: Source0: http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz 2. Group should either be "Development Tools" or "Development Libraries". 3. icicle-nc should have its permissions set to 755. MUST: The package must be named according to the Package Naming Guidelines . PASS: the package is named according to package naming guidelines. MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . PASS: The spec file name matches the base package name. MUST: The package must meet the Packaging Guidelines . PASS: package meets packaging guidelines. MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . PASS: The package is licensed under lgplv2.1 which is an approved license. MUST: The License field in the package spec file must match the actual license. [3] FAIL: The COPYING file and header files indicate the code is licensed under lgplv2.1, however, spec file indicates code licensed under lgplv2 MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] PASS: package contains a license file and that license file in %do section MUST: The spec file must be written in American English. [5] PASS: spec file written in English MUST: The spec file for the package MUST be legible. [6] PASS: spec file is very legible MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. The source0 package should be the upstream package location including url. upstream package: from SRC RPM: FAIL - md5sums do not match this is a BLOCKER [sdake@beast Downloads]$ md5sum oz-0.4.0.tar.gz cd1639af62509c677c95d94705042772 oz-0.4.0.tar.gz md5sum [sdake@beast SOURCES]$ md5sum oz-0.4.0.tar.gz d2f774e97ca5ac0c34b9f07b6ea1bd01 oz-0.4.0.tar.gz MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] PASS - I personally built on x86_64 MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] PASS - this is a noarch python package MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. PASS - I built on clean cloned f15 VM that are expected in the build root. I then installed python (build requires) and package builds properly. MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] PASS - no locale functionality is included upstream. MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] PASS - this package is python only (noarch) and does not have shared objects MUST: Packages must NOT bundle copies of system libraries.[11] PASS - no system libraries are bundled by package. MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] PASS - no request for relocate functionality. MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] PASS - all directories needed by package are owned by package or created by depends. MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] PASS - all files only listed once in a spec file MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] FAIL - icicle-nc is not set with execute permissions - THIS IS A BLOCKER MUST: Each package must consistently use macros. [16] PASS - all macros used consistently MUST: The package must contain code, or permissable content. [17] PASS - the package contains python code, man pages, and installation scripts. All content is permissible per 17. MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] PASS - there are only a few man pages, and the reviewer doesn't recommend a -doc package. MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] PASS - doc's are "%doc README COPYING" not effecting runtime if not present MUST: Header files must be in a -devel package. [19] PASS - no header files MUST: Static libraries must be in a -static package. [20] PASS - no static libraries MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] PASS - no shared objects MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [21] PASS - no devel package MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20] PASS - no libtool files MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22] PASS - there is no desktop GUI MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] PASS - the package owns the following directories: %dir %attr(0755, root, root) %{_sysconfdir}/oz/ %dir %attr(0755, root, root) %{python_sitelib}/oz %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/isocontent/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/isos/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/mnt/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/floppycontent/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/floppies/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/icicletmp/ %dir %attr(0755, root, root) %{_localstatedir}/lib/oz/jeos these are all application specific. MUST: All filenames in rpm packages must be valid UTF-8. [24] PASS - all filenames are UTF-8 encoded -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review