Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702957 --- Comment #3 from Mario BlÃttermann <mariobl@xxxxxxxxxx> 2011-06-08 08:56:59 EDT --- (In reply to comment #1) > Mario, here are some notes on your package: > > - Remove the empty folder %{_datadir}/%{name}-%{version}/src from the package. > Done. > - I suggest to move the examples to %{_datadir}/%{name}. The version number is > not required here. > Is there any advantage to do so? Anyway, done. > - You probably also want to patch the start scripts with the correct path to > the pclock binary. Currently, they don't work. > Patch has applied. > - The app only works properly on my system if switch -w is given. Otherwise, I > get a black window. Maybe -w should also be added to the start scripts. > See comment #2. > - Drop the asterisk from %{_datadir}/%{name}-%{version}/* for proper directory > ownership. Done. Updated files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/pclock.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/pclock-0.13.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review