Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710386 --- Comment #7 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-06-04 07:17:47 EDT --- (In reply to comment #6) > The package works well and is OK. Just some comments: > 1) You can remove the version condition on gnome-shell Requires, since the > stable repos already provide GS >= 3.0.1 removed > 2) About the %posttrans/%postun, you'd better rely on the guidelines: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GSettings_Schema > I suppose you were inspired by the gnome-shell-extensions. This package > will have its scriptlets fixed to according to the guidelines. fixed * Sat Jun 04 2011 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> - 0.9-2 - Scriplet updated - Version condition removed Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-system-monitor-applet.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-system-monitor-applet-0.9-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review