Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710386 --- Comment #6 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-06-03 14:44:35 EDT --- The package works well and is OK. Just some comments: 1) You can remove the version condition on gnome-shell Requires, since the stable repos already provide GS >= 3.0.1 2) About the %posttrans/%postun, you'd better rely on the guidelines: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GSettings_Schema I suppose you were inspired by the gnome-shell-extensions. This package will have its scriptlets fixed to according to the guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review