Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708475 --- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-06-01 09:39:04 EDT --- (In reply to comment #2) > Unless you plan to use this spec file with EPEL also, you can remove the > BuildRoot tag, "rm -rf $RPM_BUILD_ROOT" at the top of %install, the %clean > section, and the %defattr line in %files. Yeah, usually I would remove it but thought there might be an off chance that someone will want this on EPEL... > MUST: > [=] package meets the packaging guidelines: the canonical URL for Source0 is > actually http://downloads.sourceforge.net/pysdm/pysdm-0.4.1.tar.gz, as noted in > https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net. I should have known there was a wiki for this :) "curl -L -O..." always worked so I figured it was just rpmlint being pedantic.... Fixed. > [-] license field matches the actual license: I don't see any license > statements, except on bundled code, and the top-level COPYING file is the LGPL. > Where did "GPLv2" come from? I'm still learning how licences work... I thought that when COPYING said GPL Version two that it meant GPLv2... I knew the L was "Lesser" but didn't know that GNU Library == "Lesser" So it should be LGPL? > [-] no bundled copies of system libraries: This package bundles two files from > tepache (https://launchpad.net/tepache), namely tepache.py and > SimpleGladeApp.py. Man, I got to get better at finding bundled libraries :) Ok, what do we do here? It doesn't appear to be already packaged for Fedora so this package would be the only user. Do we need a separate review request? Strangely enough only SimpleGladeApp.py seems to make it into the rpm package... > SHOULD: > [=] package contains man pages for binaries/scripts GUI only app... Thanks, Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review