Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705585 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> 2011-05-26 11:42:28 EDT --- I fixed *some* of the problems you pointed out. See below for more information. New URLs: http://jjames.fedorapeople.org/fflas-ffpack/fflas-ffpack.spec http://jjames.fedorapeople.org/fflas-ffpack/fflas-ffpack-1.4.1-2.fc14.src.rpm (In reply to comment #3) > - license wrong: /usr/bin/fflasffpack-config is CeCILL-B > -> LGPLv2+ and CeCILL-B with a comment, which file is under which license Fixed. Good catch! > TODO: > * Please add a %check section, e.g. with "make check" > * I'm seeing: > ******************************************************************************* > WARNING: GIVARO not found! > > GIVARO version 3.4.0 or greater (<3.5) is required for some tests in this > library. > Please make sure GIVARO is installed and specify its location with the > option --with-givaro=<prefix> when running configure. > ******************************************************************************* > -> A givaro update would be needed for this to solve (don't know what exactly > is now broken in this package, maybe you?) Yes. I have updates ready for givaro and linbox once fflas-ffpack is ready. So "make check" is not going to work for fflas-ffpack until the givaro update is stable. So I think the sequence has to go like this: - New fflas-ffpack package without %check goes stable - Updated givaro and linbox packages are built and go stable - The fflas-ffpack package is updated with a %check script But that's going to break everytime we upgrade, isn't it? There's an alternative. See below. > * a doc subpackage would be really nice: Done. > * missing requires: > $ rpm -qa --requires fflas-ffpack-devel > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsXz) <= 5.2-1 > And this file: > /usr/include/fflas-ffpack/utils/args-parser.h:#include > "linbox/util/commentator.h" > -> R on linbox-devel is missing This is a problem. Since linbox BRs fflas-ffpack, this means that when building linbox we get linbox -> fflas-ffpack-devel -> linbox-devel. That is, the old linbox-devel will have to be installed to build the new linbox. Plus, linbox-devel has to Require fflas-ffpack-devel anyway, due to includes going in the opposite direction. More below. > * There are other files with wrong FSF address, but I wouldn't fix this, just > reporting upstream...: > licensecheck -r /usr/include/fflas* | grep incorrect It's easily fixed. Done, and reported upstream as well. I suspect we should rethink submitting this as a separate package. The problems with %check and requiring linbox-devel arise from the incestuous relationship between fflas-ffpack, givaro, and linbox. Plus, given upstream's penchant for breaking backward compatibility with every release, I see trouble ahead. All of this could be resolved by adding the fflas-ffpack source tarball as a second source file in the linbox spec, and building them together. We'd still have the problem of the circular dependency between linbox-devel and fflas-ffpack-devel; I don't know how to resolve that. Perhaps combine them both into linbox-devel, and make it Provides: fflas-ffpack / fflas-ffpack-devel. The downside to that approach is that it is no longer possible to update linbox and fflas-ffpack independently. But I don't think that is possible anyway. What do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review