Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967 ------- Additional Comments From dakingun@xxxxxxxxx 2006-12-31 18:22 EST ------- (In reply to comment #6) > Bad: > Release: 2 - must have the .%{?dist} tag > Requires: %name = %{version}-%{release} - inconsistent naming - should be %{name} Fixed > %{_libdir}/scigraphica/ - this takes the ownership of the directory which should > be owned by scigraphical > Maybe not. It just seems to design mistake on the part of upstream to name that directory scigraphica, its a superset of things scigraphica itself installs under it. I've modified scigraphica not to own that directory, but just install it own stuff under it. > Unsure: > Does the -devel need ldconfig to be run? I believe the package guildline says it has to be done for the package and its subpackage that contains a *.so. Corrected spec and srpms below, thanks. Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/libscigraphica-2.1.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review