Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asterisk - The Open Source PBX https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178922 ------- Additional Comments From steve@xxxxxxxxx 2006-12-31 18:19 EST ------- I'm upgrading my phone system today, so pardon the noise. :-) Issue #1: In the script you use to modify the source from Digium, you have this: # tar xf asterisk-1.4.0-beta4.tar.gz That should have been this: # tar zxf asterisk-1.4.0-beta4.tar.gz Other than that, following the directions does indeed give me identical sources (according to "diff -urN") to the source included in the src.rpm. Issue #2: I'd suggest changing %post to something like this: /sbin/chkconfig --add asterisk || : /sbin/service asterisk condrestart || : If there is a good way to do a graceful restart here, that would be even better. I'd also prefer it if %pre and %preun looked like this: %pre /usr/sbin/fedora-groupadd 31 -r asterisk || : /usr/sbin/fedora-useradd 31 -r -s /sbin/nologin -d /var/lib/asterisk -M \ -c 'Asterisk User' -g asterisk asterisk || : %preun if [ $1 = 0 ]; then /sbin/service asterisk stop || : /sbin/chkconfig --del asterisk || : fi That way we see failures, but they don't make rpm fail. When I installed the packages on my phone system (which had old asterisk/zaptel/libpri packages of mine, which might be the problem), I got the following error: Installing: zaptel ####################### [ 9/13] id: asterisk: No such user usermod: user asterisk does not exist error: %pre(asterisk-zaptel-1.4.0-6.beta4.fc6.i386) scriptlet failed, exit status 6 error: install: %pre scriptlet failed (2), skipping asterisk-zaptel-1.4.0-6.beta4.fc6 Since the asterisk %pre was redirected to /dev/null, I have no idea if there was a failure there. Again, the real problem might have been caused by old packages, but, since I don't have diagnostic output, I can't be sure. I would definitely test an install on a clean system though to be safe. So far those are the only problems that I've found. The package builds fine in mock (i386 and x86_64), and the handful of rpmlint warnings can be safely ignored. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review