[Bug 707132] Review Request: java-service-wrapper - Java service wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707132

--- Comment #3 from Miroslav Suchà <msuchy@xxxxxxxxxx> 2011-05-24 14:52:51 EDT ---
> This is not correct, because the package is not compatible with the previous
tanukiwrapper package.

True. I will remove it.

>> +- removed epoch from BR
> This is not correct either, because java-javadoc, java, and java-devel-openjdk
do have an Epoch set:
That is true for openjdk, but not for gjc, which does not have epoch set. With
epoch set we effectively enforce use of openjdk.

> This results in modifying files in the rpm source dir root, which is not okay.
No. It is modified in build root. 
a) I see nothing wrong on modifying files in buildroot. You can modify what you
want there.
b) it is build root of binary package, not src.rpm. The build root is removed
immediately after building package, so I see no way how it can affect other
builds (on different platforms/archs).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]