Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fail2ban - Ban IPs that make too many password failures https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220789 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-30 13:35 EST ------- Well: A. From http://fedoraproject.org/wiki/Packaging/Guidelines ! Licensing - Please ask upstream to include to src tarball a copy of GPL (not a blocker) = Scriptlets requirements (In reply to comment #8) > > * Would you explain why you think that condrestart treatment of the > > service on %postun stage is unneeded? > > Yes, I consider fail2ban in this respect to be as > fragile as for example the > iptables or httpd services: I don't want to automate therestart However, I found on your spec file (0.6.2-2) ------------------------------------------ %post /sbin/chkconfig --add %{name} /sbin/service %{name} condrestart > /dev/null 2>&1 <- THIS LINE ------------------------------------------ Perhaps you may want to remove the line (I don't object to it according to your opinition). Note: leaving the line needs "Requires(post): /sbin/service" B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines = okay, except for the issues on A. ------------------------------------------------------------------ This package (fail2ban) is APPROVED by me. ------------------------------------------------------------------- NOTE: the issue under discussion on fedora-maintainers about "very short APPROVED comments" was actually caused by my review....... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review