[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700818

--- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-05-02 06:16:44 EDT ---
Not a full review:


> gcc -shared -Wl,-soname,libircclient.so.1 libircclient.o -o libircclient.so

You've got it backwards. With a soname of libirrclient.so.1, the file name
ought to be libircclient.so.1 with the *.so symlink pointing to it.


> %files
> ...
> %{_libdir}/libircclient.so*

Here a dot is missing. It must be

  %{_libdir}/libircclient.so.*

so you can include the *.so symlink in the -devel package where it belongs.


> There is a problem with debuginfo generation which I haven't yet been able
> to fix.

The problem is the "-s" that strips the library:
install -s -m 0755 libircclient.so %{buildroot}%{_libdir}/

http://fedoraproject.org/wiki/Packaging/Debuginfo


> /usr/share/doc/libircclient-1.3/examples/

Looks like the wrong subpackage for these examples. The included Makefile* for
these examples are not usable, btw.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]