Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700551 --- Comment #4 from Adam Huffman <bloch@xxxxxxxxxxxx> 2011-05-02 06:14:50 EDT --- Thanks for the new version. Some more comments: - I assume you've added the Requires: line because of the issue mentioned regarding decoders? Normally the automatic checker is sufficient. - you need to use macros in the %files section e.g %{_bindir}/xwax %{_libexecdir}/xwax/xwax-import and you should own the %{_libexecdir}/xwax/ directory - you don't need the full path for those doc files %doc CHANGES COPYING README should be enough and you should use macros for the manpage %doc %{_mandir}/man1/xwax.1.gz To help persuade someone to sponsor you, it would be a good idea to submit a couple more new packages and do some informal reviews yourself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review