Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libprelude - Prelude library collection https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-29 00:52 EST ------- Well, A. Genenal packaging issues * Please add the following documentation(s) ---------------------------------------- NEWS COPYING ---------------------------------------- * Please remove the following documentation(s) ---------------------------------------- INSTALL - only need by manual installation and not needed by rpm installation ---------------------------------------- B. For debuginfo rpm issue ! It seems that some of the source files are borrowed from libgpg-error. (borrowed means "copied with some modifications for the usage of libprelude") --------------------------------------- /usr/src/debug/libprelude-0.9.12/src/libprelude-error/code-from-errno.c /usr/src/debug/libprelude-0.9.12/src/libprelude-error/code-from-errno.h /usr/src/debug/libprelude-0.9.12/src/libprelude-error/code-to-errno.c /usr/src/debug/libprelude-0.9.12/src/libprelude-error/code-to-errno.h /usr/src/debug/libprelude-0.9.12/src/libprelude-error/err-codes.h /usr/src/debug/libprelude-0.9.12/src/libprelude-error/err-sources.h /usr/src/debug/libprelude-0.9.12/src/libprelude-error/strerror.c /usr/src/debug/libprelude-0.9.12/src/libprelude-error/strsource.c --------------------------------------- Usually local copies of other libraries are forbidden, however, as long as I checked how these source codes are used, these codes can be allowed because it seems that the part of codes borrowed from libgpg-error seems very trivial. However, would you check if this is proper? (IMO this is not a blocker for this package). Then: C: Related to http://fedoraproject.org/wiki/Packaging/Guidelines * Use rpmlint ------------------------------------------------ E: libprelude-perl script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Prelude.pm ------------------------------------------------ permission should be 0644 for this file. * BuildRequires - Mockbuild fails. BuildRequires: gnutls should be BuildRequires: gnutls-devel * Parallel make - Does this package fail on parallel make? If not, please use make %{?_smp_mflags} D. Related to http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = This is okay, except for the issues on A-C. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review