Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698362 Ankur Sinha <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sanjay.ankur@xxxxxxxxx --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-04-20 15:00:52 EDT --- Some notes: 1. The patch needs a comment describing its requirement. 2. You no longer need the buildroot tag, and the clean section. 3. It's shebang, not sheband ;) 4. In the files section, at the egginfo part, use py?.?.egg-info, it'll make updates easier. 5. Do check if the python-setuptools is also a runtime requirement once. 6. I don't see a LICENSE file in the files section. Please request upstream to include one. 7. You haven't handled the desktop file. Please refer to http://fedoraproject.org/wiki/PackagingGuidelines#Desktop_files for details 8. Isn't there an icon (Since there is a desktop file?) The spec looks okay at a glance, but a detailed review might reveal more issues. Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review