[Bug 690728] Review Request: Nitrate - A test case management system written in Django

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690728

--- Comment #11 from Yuguang Wang <yuwang@xxxxxxxxxx> 2011-04-14 05:22:13 EDT ---
(In reply to comment #9)
> > %{_datadir}/%{name}/*
> 
> And after many years, this is still a packaging mistake.
Removed the asterisks from spec file.

(In reply to comment #10)
> - source line is invalid. It includes %{release} which would include the
> disttag that spectool is called from (e.g. 4.fc15 instead of 4). Any reason
> spec releases should have matching tarballs? normally a single tarball is
> released per version, and you bump the version number if you need to release a
> fix. The spec release simply tracks spec changes
> 
Indeed.

> - the comment for the section dealing with static content is just wrong. They
>   are not being moved from arch-specific Python directories (in fact the
> package
>   is actually noarch anyway) but are copied from the source directory
Wow, thanks!

The newly updated spec file:
https://fedorahosted.org/nitrate/browser/trunk/nitrate/nitrate.spec

And the new srpm:
https://fedorahosted.org/releases/n/i/nitrate/nitrate-3.3.4-1.src.rpm

Hope it works this time, any problems please let me know :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]