[Bug 668240] Review Request: clapham - Railroad diagram generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668240

--- Comment #2 from Eric Smith <eric@xxxxxxxxxxxx> 2011-04-07 06:24:39 EDT ---
Thanks for reviewing this!

Changed more occurences of package name to %{name} per your suggestion.

I don't see how install is in any way better than cp here.  However, I have
replaced the first two uses of cp with install.  Since install does not appear
to have a recursive option, and use of find with install definitely doesn't
improve the clarity, I have retained the use of cp -a for that one.

Changed the summary per your suggestion.

Spec URL: http://fedorapeople.org/~brouhaha/clapham/clapham.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/clapham/clapham-0.1.003-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]