[Bug 668240] Review Request: clapham - Railroad diagram generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668240

Mario BlÃttermann <mariobl@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mariobl@xxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mariobl@xxxxxxxxxx

--- Comment #1 from Mario BlÃttermann <mariobl@xxxxxxxxxx> 2011-04-02 18:17:50 EDT ---
$ rpmlint -v *
clapham.src: I: checking
clapham.src: I: checking-url http://clapham.hydromatic.net/ (timeout 10
seconds)
clapham.src: I: checking-url
http://downloads.sourceforge.net/clapham/clapham-0.1.003-src.zip (timeout 10
seconds)
clapham.spec: I: checking-url
http://downloads.sourceforge.net/clapham/clapham-0.1.003-src.zip (timeout 10
seconds)
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

No issues from rpmlint, OK.

Some hints anyway:

- For better consistency, replace all occurences of th package name with
%{name}.
- In my mind, it's better to use the universal "install" command instead of
"cp".
- To avoid ambiguity, you could append "...for computer languages" to summary.
  Otherwise, readers could assume it is a generator for railway maps ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]