Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676129 --- Comment #19 from Ivan Romanov <drizt@xxxxxxx> 2011-03-31 15:37:35 EDT --- (In reply to comment #16) > Well, I don't think you need to copy Kevin's fragment exactly. I linked it to > provide inspiration. For instance, I don't think you really need to add > -Wno-non-virtual-dtor. And there's no pkg-config usage in this project, so I > don't see any value in PKGCONFIG_CFLAGS either. I have rewrited patch. Now I just override QMAKE_CXXFLAGS_RELEASE and QMAKE_CXXFLAGS_DEBUG with value from CXXFLAGS if it's possible. In negative order it's used value from Qt. Also I switched off warning. https://github.com/drizt/psi-plus/blob/e24acf78de103730848946ece8d721ddba3009ca/qconf-1.4-optflags.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review