Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676939 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-03-25 10:25:05 EDT --- I wonder about a few additional things: > Name: libeiskaltdcpp > Source0: http://eiskaltdc.googlecode.com/files/eiskaltdcpp-2.2.0.tar.bz2 > Library packages do not need to start with a "lib" prefix: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming It seems the upstream name is not libeiskaltdcpp, and other distributions have not called their packages like that either. > Requires: openssl >= 0.9.8 As Sergio has pointed out, "BuildRequires: openssl-devel" seems to be missing, but the explicit dependency on "openssl" should be revisited according to: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %description I would consider the description better, if it were much more like the current Summary. That is, if it described that this is a library package and what that library can do. Instead, it refers to a "cross-platform program" and "other DC clients", even mentions their names. This is quite confusing. If the library offers an API for the DC and ADC protocols and could be used by developers for programs other than EiskaltDC++, the description could be made much more concise. > %post > /sbin/ldconfig > > %postun > /sbin/ldconfig This would execute /sbin/ldconfig via a /bin/sh script and add an additional dependency on /bin/sh. The following would execute /sbin/ldconfig directly and add a dependency on /sbin/ldconfig: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig > make install/strip DESTDIR=%{buildroot} Without having tried to build this, the "strip" here is suspicious. No files should not be stripped, because rpmbuild does that when extracting the debuginfo details. > %files -f %{name}.lang > %defattr(-,root,root,-) > %{_libdir}/libeiskaltdcpp.so.2.2 > %doc COPYING > %doc LICENSE No libeiskaltdcpp-devel package? Where are the header files for this library? And where is the libeiskaltdcpp.so symlink needed for compiling software? Isn't this an ordinary library with a public API to develop with? Also, the install appears to be incomplete, because the symlink for %{_libdir}/libeiskaltdcpp.so.2 is missing currently. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review