[Bug 676939] Review Request: libeiskaltdcpp - A client library for the DC file sharing protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676939

Sergio Belkin <sebelk@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebelk@xxxxxxxxx

--- Comment #2 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-02-18 08:38:38 EST ---
Hi,

I think that you should use tools like koji and mock in order to be sure that
package is built. Currently it is failing on koji:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:91
(MESSAGE):
  Could NOT find OpenSSL (missing: OPENSSL_LIBRARIES OPENSSL_INCLUDE_DIR)

AFAIS, openssl-devel is missing in BuildRequires.

Also you should fix the permission on tarball file. Remove the execution mode
bits. And on spec file: use %post -p <command> instead of using:  %post
<command>, the same goes for the %postun section.

Besides you may find the following pages really useful:

http://fedoraproject.org/wiki/Common_Rpmlint_issues
http://fedoraproject.org/wiki/How_to_create_an_RPM_package
http://fedoraproject.org/wiki/Packaging:Guidelines
http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
http://fedoraproject.org/wiki/PackageMaintainers/UsingKoji

Still I am not a sponsor but I hope that it helps :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]