Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684239 --- Comment #12 from Raul Gutierrez S. <rgs@xxxxxxxxxxxxx> 2011-03-14 18:20:51 EDT --- (In reply to comment #11) > Issues: > [!] : MUST - Development .so files in -devel subpackage, if present. > valadoc-0.2.1-1.fc16.i686.rpm : > /usr/lib/valadoc/plugins/devhelp/libdoclet.so > valadoc-0.2.1-1.fc16.i686.rpm : > /usr/lib/valadoc/plugins/gtkdoc/libdoclet.so > valadoc-0.2.1-1.fc16.i686.rpm : > /usr/lib/valadoc/plugins/html/libdoclet.so > > I'm a little unsure about these .so files, if they are not need at > runtime, then they should go into -devel > but if they are needed it is ok. They are dynamically opened via g_module_open(). > > [!] : SHOULD - Spec use %global instead of %define. > %define glib_ver 2.25.16 > %define gobj_ver 0.9.3 > %define vala_ver 0.10.2 > %define gee_ver 0.5 > %define gdk_ver 2.0 > > use %global instead of %define Done. > Add COPYING from upstream to %doc, replace %define with %global and I will > approve it Done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review