Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682353 --- Comment #2 from Mario BlÃttermann <mariobl@xxxxxxxxx> 2011-03-05 05:38:48 EST --- Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/wmtop.spec SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/wmtop-0.84-2.fc14.src.rpm (In reply to comment #1) > Some initial comments: > > - The proper project site of wmtop seems to be http://wmtop.sourceforge.net. > You should adapt URL and Source0 accordingly. The project page is still present, but the download location is down. It's a common problem with a lot of older dockapps. That's why it is a good choice to link to the pool at dockapps.org here > > - Replace CFLAGS with OPTS in the make statement. Otherwise, the %{optflags} > don't get applied. Done. > > - Add -p to "install" in order to preserve the timestamps, especially that of > the manpage. > Done. > - Replace %{name}.1.gz with %{name}.1* since you should not rely on a specific > compression format (as it may change). Done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review