Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682353 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-03-05 03:46:48 EST --- Some initial comments: - The proper project site of wmtop seems to be http://wmtop.sourceforge.net. You should adapt URL and Source0 accordingly. - Replace CFLAGS with OPTS in the make statement. Otherwise, the %{optflags} don't get applied. - Add -p to "install" in order to preserve the timestamps, especially that of the manpage. - Replace %{name}.1.gz with %{name}.1* since you should not rely on a specific compression format (as it may change). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review