Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680268 --- Comment #3 from Mario BlÃttermann <mariobl@xxxxxxxxx> 2011-02-25 14:31:08 EST --- (In reply to comment #1) > Few comments: > - Please read http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > You SHOULD NOT point bash to BuildRequirements Removed. > - libXpm-devel depends on libx11-devel and libXext-devel. No, mock build fails without libXext-devel. > - If you plan build package for EPEL you must add %clean section. If not, you > can remove BuildRoot section: > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Don't know if I should provide a dockapp package for EPEL. (In reply to comment #2) > Some additional notes: > > - please use macros and variables consistently: > $RPM_BUILD_ROOT and $RPM_OPT_FLAGS or > %{buildroot} and %{optflags} > > - you can simplify the %build section by using the single line > make CFLAGS='%{optflags}' %{?_smp_mflags} > (cd is not required here, and the given LIB dir doesn't exist in Fedora) > cd is required here, because the Makefile resides in /src. > - in the %install section, install the binary with > install -m 755 %{name} %{buildroot}%{_bindir} > > - The 3 additional folders %_iconsdir, %_iconsdir, and %_lconsdir are not used. > The corresponding installs should therefore be dropped. > Removed. > - please also set the file permissions of the source tarball to 644 > Done. > - personally, I'd prefer a German summary like this: > "Dockapp zur Anzeige von Prozessorlast und Speicherverbrauch" > Something similar could also be used in the %description to avoid mentioning > the grammatical gender of "Dockapp" which is female rather than neuter to my > feeling. :) I have changed it. However, the modern Âapps as known from the Âapp stores are female. But ÂDockapp means ÂDockable appletÂ, and this is not female. Grrr, in German we have thirteen cases of the English ÂtheÂ, it's sometimes difficult... Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/cputnik.spec SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/cputnik-0.2.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review