Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680268 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-02-25 03:27:55 EST --- Some additional notes: - please use macros and variables consistently: $RPM_BUILD_ROOT and $RPM_OPT_FLAGS or %{buildroot} and %{optflags} - you can simplify the %build section by using the single line make CFLAGS='%{optflags}' %{?_smp_mflags} (cd is not required here, and the given LIB dir doesn't exist in Fedora) - in the %install section, install the binary with install -m 755 %{name} %{buildroot}%{_bindir} - The 3 additional folders %_iconsdir, %_iconsdir, and %_lconsdir are not used. The corresponding installs should therefore be dropped. - please also set the file permissions of the source tarball to 644 - personally, I'd prefer a German summary like this: "Dockapp zur Anzeige von Prozessorlast und Speicherverbrauch" Something similar could also be used in the %description to avoid mentioning the grammatical gender of "Dockapp" which is female rather than neuter to my feeling. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review