Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643679 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Steve Traylen <steve.traylen@xxxxxxx> 2011-02-24 13:12:16 EST --- Note to Denis, if you want to be able review packages see: http://fedoraproject.org/wiki/PackageMaintainers/Join Review of globus-gridmap-callout-error Mock , f14 x86_64 okay. rpmlint of .spec, srpm, noarch and x86_64 bit packages: $ rpmlint ./globus-gridmap-callout-error.spec \ ../SRPMS/globus-gridmap-callout-error-0.3-1.fc14.src.rpm \ ../RPMS/noarch/globus-gridmap-callout-error-doc-0.3-1.fc14.noarch.rpm \ ../RPMS/x86_64/globus-gridmap-callout-error-* ./globus-gridmap-callout-error.spec: W: invalid-url Source0: globus_gridmap_callout_error-0.3.tar.gz globus-gridmap-callout-error.src: W: invalid-url Source0: globus_gridmap_callout_error-0.3.tar.gz globus-gridmap-callout-error-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package globus-gridmap-callout-error. globus-gridmap-callout-error-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 1 errors, 3 warnings. which are all okay, Source is from a bigger source. long line is only in the debuginfo package which is to hard to work around. Globus Guidelines: http://fedoraproject.org/wiki/Packaging:Globus - Package meets naming and packaging guidelines Globus - Spec file matches base package name. Globus - Spec has consistant macro usage. It does. - Meets Packaging Guidelines. Yes, the globus ons in particular. - License ASL 2.0 - License field in spec matches All files have an apche header. - License file included in package GLOBUS_LICENSE - Spec in American English It is. - Spec is legible. It is. - Sources match upstream md5sum: Reconstucting the source: wget -N http://www-unix.globus.org/ftppub/gt5/5.0/5.0.2/installers/src/gt5.0.2-all-source-installer.tar.bz2 tar -jxf gt5.0.2-all-source-installer.tar.bz2 gt5.0.2-all-source-installer/source-trees/gsi/gridmap_callout/error tar zxvf globus_gridmap_callout_error-0.3.tar.gz $ diff --brief -r globus_gridmap_callout_error-0.3/ gt5.0.2-all-source-installer/source-trees/gsi/gridmap_callout/error Only in globus_gridmap_callout_error-0.3/: GLOBUS_LICENSE which is expected. - Package needs ExcludeArch Not checked. - BuildRequires correct It is. - Spec handles locales/find_lang None present. - Package is relocatable and has a reason to be. Not relocatable. - Package has %defattr and permissions on files is good. It does. - Package has a correct %clean section. It does. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. Yes. - Doc subpackage needed/used. Yes a doc sub package is created. - Packages %doc files don't affect runtime. Fine - Headers/static libs in -devel subpackage. Fine. - Spec has needed ldconfig in post and postun It doe.s - .pc files in -devel subpackage/requires pkgconfig Yes for Fedora but see below. - .so files in -devel subpackage. Yes. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. They are indeed. - Package is a GUI app and has a .desktop file No gui. - Package compiles and builds on at least one arch. Mock - Package has no duplicate files in %files. There are not. - Package doesn't own any directories other packages own. It's fine. - Package owns all the directories it creates. It does. - final provides and requires are sane: ===== globus-gridmap-callout-error-0.3-1.fc14.src.rpm == provides == requires grid-packaging-tools globus-common-devel(x86-64) >= 3 globus-gssapi-error-devel(x86-64) >= 2 globus-core(x86-64) >= 4 doxygen graphviz ghostscript tex(latex) ===== globus-gridmap-callout-error-0.3-1.fc14.x86_64.rpm == provides libglobus_gridmap_callout_error.so.0()(64bit) globus-gridmap-callout-error = 0.3-1.fc14 globus-gridmap-callout-error(x86-64) = 0.3-1.fc14 == requires /sbin/ldconfig /sbin/ldconfig globus-common libglobus_common.so.0()(64bit) libglobus_gridmap_callout_error.so.0()(64bit) ===== globus-gridmap-callout-error-debuginfo-0.3-1.fc14.x86_64.rpm == provides globus-gridmap-callout-error-debuginfo = 0.3-1.fc14 globus-gridmap-callout-error-debuginfo(x86-64) = 0.3-1.fc14 == requires ===== globus-gridmap-callout-error-devel-0.3-1.fc14.x86_64.rpm == provides pkgconfig(globus-gridmap-callout-error) = 0.3 globus-gridmap-callout-error-devel = 0.3-1.fc14 globus-gridmap-callout-error-devel(x86-64) = 0.3-1.fc14 == requires /usr/bin/pkg-config globus-common-devel(x86-64) >= 3 globus-core(x86-64) >= 4 globus-gridmap-callout-error(x86-64) = 0.3-1.fc14 globus-gssapi-error-devel(x86-64) >= 2 libglobus_gridmap_callout_error.so.0()(64bit) pkgconfig(globus-common) >= 3 pkgconfig(globus-core) >= 4 pkgconfig(globus-gssapi-error) >= 2 ===== globus-gridmap-callout-error-doc-0.3-1.fc14.noarch.rpm == provides globus-gridmap-callout-error-doc = 0.3-1.fc14 == requires globus-gridmap-callout-error = 0.3-1.fc14 SHOULD Items: - Should build in mock. It does. - Should build on all supported archs Not checked. - Should function as described. Not checked. - Should have sane scriptlets. It does. - Should have subpackages require base package with fully versioned depend. They do including the isa tag - Should have dist tag Yes. - Should package latest version Not checked but it's the "right" version. Issues: Just the one EPEL 5 needs a Requires for pkgconfig unless this gets pulled in by one of the devel allready pulled in which is quite possible. Check before committing. On the whole a text book globus package. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review