Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-02-22 13:28:09 EST --- Here are some additional comments: - please always post links to the updated spec and srpm files - the Release count should start with 1 (not with 0) - 2011.02.20git is not a valid version number. Replace it with 2011.02.20 as this seems to be the version number chosen by upstream. - change the Release field according to http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages e.g. Release: 0.%{X}.20110222git%{REV}%{?dist} where %{X} is the revision number to increase, and %{REV} is the Git changeset hash used to build the package - add a comment above Source0 with the commands required to recreate the tarball with the same content - According to the source file headers, the license is GPLv2+. I recommend to ask the experts on the legal mailing list whether it's necessary to declare the mentioned exception. - the package doesn't build in mock because of missing BR: glew-devel - you should drop Requires: opencsg as the dependency is detected automatically - also drop Requires: desktop-file-utils - add Requires: hicolor-icon-theme - remove the --vendor switch from desktop-file-install - adapt the icon cache scriptlets according to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache - replace %{_datadir}/%{name}/* with %{_datadir}/%{name}/ for proper directory ownership. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review