Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 --- Comment #5 from jebba <moe@xxxxxxxxxxxxxxxx> 2011-02-22 03:45:10 EST --- (In reply to comment #4) > Required > ========= > [!] named according to the Package Naming Guidelines > *** 20110220git is a more appropriate version number or an abbreviated git > hash. See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines Upstream gives their latest release names like 2010.05, so I wanted to stay in line with that. Also, when you go to Help-->About in the program it gives a version number like 2011.02.21. I agree it is a bit ugly, but it is also tracking upstream releases. > [!] The License field in the package spec file must match the actual license > *** GPLv2+ rather than GPLv2 I think it is actually "GPLv2 with exceptions". GPLv2+ is GPLv2 or any later versions. This one has exceptions to allow it to play ok with CGAL. > [!] GUI apps must include a %{name}.desktop file, properly installed with > desktop-file-install in the %install section > *** no desktop file or icon included - query upstream or create as additional > sources I have added them. > Should Items > ============ > [!] Should contain man pages for binaries/scripts > *** however, PDF docs are supplied No man pages available. Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review