Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642208 --- Comment #3 from amorilia@xxxxxxxxxxxxxxxxxxxxx 2011-02-21 13:25:02 EST --- Thanks - I've learnt a lot! Agreed with all changes. If I had special packager powers, I would approve your package, but until that time, it will be up to a real packager. For the sake of sanity checking, rpmlint output for the update package below. Everything looks ok, as expected. Rpmlint ------- $ rpmlint mingw32-win-iconv.spec mingw32-win-iconv.spec: W: invalid-url Source0: http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. As before, spurious warning. $ rpmlint mingw32-win-iconv-0.0.2-1.fc15.src.rpm mingw32-win-iconv.src: W: invalid-url Source0: http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. As before, spurious warning. $ rpm -i mingw32-win-iconv-0.0.2-1.fc15.src.rpm $ md5sum ~/rpmbuild/SOURCES/win-iconv-0.0.2.tar.bz2 4300d7f337a3c13ab255d4d855057c16 $ curl -s http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 | md5sum 4300d7f337a3c13ab255d4d855057c16 $ diff mingw32-win-iconv.spec ~/rpmbuild/SPECS/mingw32-win-iconv.spec -s Files mingw32-win-iconv.spec and /home/amorilia/rpmbuild/SPECS/mingw32-win-iconv.spec are identical $ rpmbuild -ba mingw32-win-iconv.spec ... Build succeeds. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-0.0.2-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-debuginfo-0.0.2-1.fc14.noarch.rpm mingw32-win-iconv-debuginfo.noarch: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-static-0.0.2-1.fc14.noarch.rpm mingw32-win-iconv-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libiconv.a mingw32-win-iconv-static.noarch: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Looks fine, follows MinGW guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review