Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #5 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-02-19 15:59:16 EST --- (In reply to comment #4) > (This is not normal review, because I am novice packager, but a bit of of > feedback): Thanks Patryk for your time. > > 1) You're missing %doc in your files section, maybe fill it like this: > > %files > %defattr(-,root,root,-) > %doc COPYING AUTHORS ChangeLog NEWS README THANKS Done! Updated files: Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-4.fc16.src.rpm > > it will take named files from unpacked tarball and place it correctly in > %{_docdir}/%{name}-%{version}, where they belong :) > You completely have to do it at least for COPYING file. > > 2) I don't think you need > %attr(755,root,root) before %{_bindir}/* > > make install should already take care of that Yes it should, I don't think that it was harmful, however, I've removed :) > > 3) (aesthetics, it doesn't really matter ;)) > - add/remove some spaces before values for fields: Name,Release and Requires - > to make all values start in same column > - remove unneeded multiple spaces after Requires fields I've fixed that too, now spec file looks great, doesn't it? Thanks again you say that you're novice, but the suggestions were quite usefuel. I look forward for your review and sponsorship, if you need that I fix anything else, let me know. Cheers rpmlint output: [sergio@peque tmp]$ for i in cdw-0.6.0-4*rpm ~/rpmbuild/SPECS/UpTools.spec; do echo "rpmlint -i -v $i:" && rpmlint -i -v $i;done rpmlint -i -v cdw-0.6.0-4.fc16.i686.rpm: cdw.i686: I: checking cdw.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-0.6.0-4.fc16.src.rpm: cdw.src: I: checking cdw.src: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) cdw.src: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-0.6.0-4.fc16.x86_64.rpm: cdw.x86_64: I: checking cdw.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v /home/sergio/rpmbuild/SPECS/UpTools.spec: /home/sergio/rpmbuild/SPECS/UpTools.spec: I: checking-url http://www.palermo.edu/ingenieria/UpTools-8.5.4.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpm -qlp output: rpm -qlp cdw-0.6.0-4.fc16.i686.rpm: /usr/bin/cdw /usr/share/doc/cdw-0.6.0 /usr/share/doc/cdw-0.6.0/AUTHORS /usr/share/doc/cdw-0.6.0/COPYING /usr/share/doc/cdw-0.6.0/ChangeLog /usr/share/doc/cdw-0.6.0/NEWS /usr/share/doc/cdw-0.6.0/README /usr/share/doc/cdw-0.6.0/THANKS /usr/share/man/man1/cdw.1.gz rpm -qlp cdw-0.6.0-4.fc16.src.rpm: cdw-0.6.0.tar.gz cdw.spec rpm -qlp cdw-0.6.0-4.fc16.x86_64.rpm: /usr/bin/cdw /usr/share/doc/cdw-0.6.0 /usr/share/doc/cdw-0.6.0/AUTHORS /usr/share/doc/cdw-0.6.0/COPYING /usr/share/doc/cdw-0.6.0/ChangeLog /usr/share/doc/cdw-0.6.0/NEWS /usr/share/doc/cdw-0.6.0/README /usr/share/doc/cdw-0.6.0/THANKS /usr/share/man/man1/cdw.1.gz Thanks again -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review