Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Patryk Obara <dreamer.tan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dreamer.tan@xxxxxxxxx --- Comment #4 from Patryk Obara <dreamer.tan@xxxxxxxxx> 2011-02-19 14:13:15 EST --- (This is not normal review, because I am novice packager, but a bit of of feedback): 1) You're missing %doc in your files section, maybe fill it like this: %files %defattr(-,root,root,-) %doc COPYING AUTHORS ChangeLog NEWS README THANKS it will take named files from unpacked tarball and place it correctly in %{_docdir}/%{name}-%{version}, where they belong :) You completely have to do it at least for COPYING file. 2) I don't think you need %attr(755,root,root) before %{_bindir}/* make install should already take care of that 3) (aesthetics, it doesn't really matter ;)) - add/remove some spaces before values for fields: Name,Release and Requires - to make all values start in same column - remove unneeded multiple spaces after Requires fields -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review