Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674006 Rich Mattes <richmattes@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Rich Mattes <richmattes@xxxxxxxxx> 2011-02-09 09:29:18 EST --- Alright it looks like you've taken care of everything. You might want to consider using the %doc macro instead of manually installing the docs in the doc package, e.g. %doc Source/DoxyGen/html/* which will place them in /usr/share/doc. It makes the file install path consistent with other *-doc packages. I can't find an active upstream for the glh stuff anywhere. Itâs just used for the example apps and isnât exposed as an API anywhere, so I think it's safe to just leave it as is. rpmlint is still complaining about the changelogs because it expects a . in front of "git4c9ff978" These last comments aren't blockers, just suggestions. So, APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review