Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674006 --- Comment #4 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2011-02-08 16:30:02 EST --- (In reply to comment #3) > libraries should be deleted explicitly in %prep. This should include Done. > Itâs not a problem now, but if you do add version suffixes to the libraries, > youâll probably have to un and re-register the libraries on upgrade. The > .so.suffix could change with new api versions. Also, is niReg creating a file > somewhere? If so, your package should own it if niReg -u doesnât delete it (so > it doesnât get left behind on uninstall). The libraries are plugins, therefore they don't need version numbers. > I donât really understand your rationale for leaving the changelog entry > different than the package version number. Changelog E-V-R doesnât have > anything to do with the source tarball, and the actual version of the package > works out to 1.0.0.25-0.2.git4c9ff978. There shouldnât be a .fc14 in there > either. I tried to mute rpmlint. But I agree and have removed the dist tag from changelog entries. > [-] MUST: The package must meet the Packaging Guidelines . > Bundled library and changelog notes above Done. > [-] MUST: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package must be included in %doc. > > Is there any reason the GPL text is also included? No, removed. > [-] MUST: Packages must NOT bundle copies of system libraries. > See above notes. It didn't, I patched them out. GL and Libs are deleted in %prep now, glh headers are C++ template headers, which are directly compiled into objects. The libraries are BSD licensed and do not seem to be available stand-alone but only as part of some NVidia SDK. > [-] MUST: Packages containing GUI applications must include a %{name}.desktop > file, and that file must be properly installed with desktop-file-install in the > %install section. If you feel that your packaged GUI application does not need > a .desktop file, you must put a comment in the spec file with your explanation. > The niViewer stuff in the samples is creating GUIs, you might want to note that > you donât want to include .desktop files. Added note in %files section. New SRPM at http://fedorapeople.org/~timn/robotics/openni-1.0.0.25-0.3.git4c9ff978.fc14.src.rpm, spec changed in place. Changed license to include BSD for glh headers. Renamed samples to examples sub-package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review