Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-02-03 12:05:54 EST --- (In reply to comment #3) > (In reply to comment #1) > > Will take this one. The package builds fine in koji. Most review guidelines > > pass except for the following > > > > * URL and Source0 are wrong, still referring to the sqlite3-ruby package ones, > > please update to new locations: http://rubygems.org/gems/sqlite3 > > I have updated the Source0 link, however I updated the URL just slightly, still > left it pointing to rubyforge as long as it is not clear what is homepage of > this project. I have risen upstream ticket for clarification: > https://github.com/luislavena/sqlite3-ruby/issues/issue/26 > Hrm ok, but 'homepage' for the project at http://rubygems.org/gems/sqlite3 points to https://github.com/luislavena/sqlite3-ruby . Please consider changing this before pushing (or once the upstream bug you filed is resolved). > Version added according to Mamoru's hint. However now, rpmlint complains: > rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby > > This should be probably ignored as Mamoru stated in email: > > - on rawhide (on rawhide only) rubygem-sqlite3 should obsolete > rubygem-sqlite3-ruby (Provides: rubygem(sqlite3-ruby) should _not_ be added > to rubygem-sqlite3, just obsolete rubygem-sqlite3-ruby) > > and I am going to push this gem just for rawhide. Sounds good. > > Spec URL: http://people.redhat.com/vondruch/rubygem-sqlite3.spec > SRPM URL: > http://people.redhat.com/vondruch/rubygem-sqlite3-1.3.3-2.fc14.src.rpm > > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2759569 This Koji url refers to the -1 build, I verified -2 works as well http://koji.fedoraproject.org/koji/taskinfo?taskID=2760161 Everything looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review