Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 --- Comment #3 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-02-03 05:27:31 EST --- (In reply to comment #1) > Will take this one. The package builds fine in koji. Most review guidelines > pass except for the following > > * URL and Source0 are wrong, still referring to the sqlite3-ruby package ones, > please update to new locations: http://rubygems.org/gems/sqlite3 I have updated the Source0 link, however I updated the URL just slightly, still left it pointing to rubyforge as long as it is not clear what is homepage of this project. I have risen upstream ticket for clarification: https://github.com/luislavena/sqlite3-ruby/issues/issue/26 > * you can remove the BuildRoot tag and the "rm -rf %{buildroot}" at the > beginning of %install Done > * please change "%define ruby_sitearch" to "%global ruby_sitearch" at the top > of the spec file Done > * rpmlint looks good > > > $ rpmlint rpmbuild/RPMS/x86_64/rubygem-sqlite3-* rpmbuild/SRPMS/rubygem-sqlite3-1.3.3-1.fc14.src.rpm > > rubygem-sqlite3.x86_64: I: enchant-dictionary-not-found en_US > > Can be ignored > > > rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby > > Believe this is what we intend and can be ignored. > > > rubygem-sqlite3-doc.x86_64: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/sqlite3-1.3.3/ri/SQLite3/Database/authorizer%3d-i.yaml %3d > > Can be ignored > > > rubygem-sqlite3.src:22: W: unversioned-explicit-obsoletes rubygem-sqlite3-ruby > > I believe we can ignore this as we should retire the rubygem-sqlite3-ruby > package after this. Version added according to Mamoru's hint. However now, rpmlint complains: rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby This should be probably ignored as Mamoru stated in email: - on rawhide (on rawhide only) rubygem-sqlite3 should obsolete rubygem-sqlite3-ruby (Provides: rubygem(sqlite3-ruby) should _not_ be added to rubygem-sqlite3, just obsolete rubygem-sqlite3-ruby) and I am going to push this gem just for rawhide. > Everything else looks good. Spec URL: http://people.redhat.com/vondruch/rubygem-sqlite3.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-sqlite3-1.3.3-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2759569 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review